Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BillingRP] Correcting the API response as per the actual implementation. Removing LineOfCredit API from 2019 version, it was never supported. #8290

Merged
merged 4 commits into from
Feb 5, 2020
Merged

[BillingRP] Correcting the API response as per the actual implementation. Removing LineOfCredit API from 2019 version, it was never supported. #8290

merged 4 commits into from
Feb 5, 2020

Conversation

asarkar84
Copy link
Contributor

@asarkar84 asarkar84 commented Feb 4, 2020 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@asarkar84 asarkar84 requested a review from wilcobmsft as a code owner February 4, 2020 00:56
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Feb 4, 2020 •
edited
Loading

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from fbe8275 with merge commit b53a498. SDK Automation 13.0.17.20191226.1
  • ️✔️@azure/arm-billing [Logs]  [Release SDK Changes] 
    [npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/billingManagementClient.js → ./dist/arm-billing.js...
[npmPack] created ./dist/arm-billing.js in 750ms

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Feb 4, 2020 •
edited
Loading

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from fbe8275 with merge commit b53a498. SDK Automation 13.0.17.20191226.1
  • ️✔️sdk/billing/mgmt-v2017_02_27_preview [Logs]  [Release SDK Changes]
  • ️✔️sdk/billing/mgmt-v2017_04_24_preview [Logs]  [Release SDK Changes]
  • ️✔️sdk/billing/mgmt-v2018_03_01_preview [Logs]  [Release SDK Changes]
  • ⚠️sdk/billing/mgmt-v2018_11_01_preview [Logs]  [Release SDK Changes] 
      [mvn] [ERROR] COMPILATION ERROR : 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/billing/mgmt-v2018_11_01_preview/src/main/java/com/microsoft/azure/management/billing/v2018_11_01_preview/implementation/PriceSheetsInner.java:[130,39] method getPostOrDeleteResultWithHeadersAsync in class com.microsoft.azure.AzureClient cannot be applied to given types;
[mvn]   required: rx.Observable>,java.lang.reflect.Type,java.lang.Class
[mvn]   found: rx.Observable>,com.microsoft.azure.LongRunningOperationOptions,java.lang.reflect.Type,java.lang.Class
[mvn]   reason: cannot infer type-variable(s) T,THeader
[mvn]     (actual and formal argument lists differ in length)
[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-billing: Compilation failure
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/billing/mgmt-v2018_11_01_preview/src/main/java/com/microsoft/azure/management/billing/v2018_11_01_preview/implementation/PriceSheetsInner.java:[130,39] method getPostOrDeleteResultWithHeadersAsync in class com.microsoft.azure.AzureClient cannot be applied to given types;
[mvn] [ERROR]   required: rx.Observable>,java.lang.reflect.Type,java.lang.Class
[mvn] [ERROR]   found: rx.Observable>,com.microsoft.azure.LongRunningOperationOptions,java.lang.reflect.Type,java.lang.Class
[mvn] [ERROR]   reason: cannot infer type-variable(s) T,THeader
[mvn] [ERROR]     (actual and formal argument lists differ in length)
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
    • ⚠️sdk/billing/mgmt-v2019_10_01_preview [Logs]  [Release SDK Changes] 
        [mvn] [ERROR] COMPILATION ERROR : 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/billing/mgmt-v2019_10_01_preview/src/main/java/com/microsoft/azure/management/billing/v2019_10_01_preview/implementation/PriceSheetsInner.java:[146,39] method getPostOrDeleteResultWithHeadersAsync in class com.microsoft.azure.AzureClient cannot be applied to given types;
[mvn]   required: rx.Observable>,java.lang.reflect.Type,java.lang.Class
[mvn]   found: rx.Observable>,com.microsoft.azure.LongRunningOperationOptions,java.lang.reflect.Type,java.lang.Class
[mvn]   reason: cannot infer type-variable(s) T,THeader
[mvn]     (actual and formal argument lists differ in length)
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/billing/mgmt-v2019_10_01_preview/src/main/java/com/microsoft/azure/management/billing/v2019_10_01_preview/implementation/PriceSheetsInner.java:[303,39] method getPostOrDeleteResultWithHeadersAsync in class com.microsoft.azure.AzureClient cannot be applied to given types;
[mvn]   required: rx.Observable>,java.lang.reflect.Type,java.lang.Class
[mvn]   found: rx.Observable>,com.microsoft.azure.LongRunningOperationOptions,java.lang.reflect.Type,java.lang.Class
[mvn]   reason: cannot infer type-variable(s) T,THeader
[mvn]     (actual and formal argument lists differ in length)
[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-billing: Compilation failure: Compilation failure: 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/billing/mgmt-v2019_10_01_preview/src/main/java/com/microsoft/azure/management/billing/v2019_10_01_preview/implementation/PriceSheetsInner.java:[146,39] method getPostOrDeleteResultWithHeadersAsync in class com.microsoft.azure.AzureClient cannot be applied to given types;
[mvn] [ERROR]   required: rx.Observable>,java.lang.reflect.Type,java.lang.Class
[mvn] [ERROR]   found: rx.Observable>,com.microsoft.azure.LongRunningOperationOptions,java.lang.reflect.Type,java.lang.Class
[mvn] [ERROR]   reason: cannot infer type-variable(s) T,THeader
[mvn] [ERROR]     (actual and formal argument lists differ in length)
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/billing/mgmt-v2019_10_01_preview/src/main/java/com/microsoft/azure/management/billing/v2019_10_01_preview/implementation/PriceSheetsInner.java:[303,39] method getPostOrDeleteResultWithHeadersAsync in class com.microsoft.azure.AzureClient cannot be applied to given types;
[mvn] [ERROR]   required: rx.Observable>,java.lang.reflect.Type,java.lang.Class
[mvn] [ERROR]   found: rx.Observable>,com.microsoft.azure.LongRunningOperationOptions,java.lang.reflect.Type,java.lang.Class
[mvn] [ERROR]   reason: cannot infer type-variable(s) T,THeader
[mvn] [ERROR]     (actual and formal argument lists differ in length)
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Feb 4, 2020 •
      edited
      Loading

      azure-sdk-for-go - Release

      ⚠️ warning [Logs] [Expand Details]
      • ⚠️ Generate from fbe8275 with merge commit b53a498. SDK Automation 13.0.17.20191226.1
      • ⚠️preview/billing/mgmt/2017-02-27-preview [Logs]  
          No file is changed.
        • ⚠️preview/billing/mgmt/2017-04-24-preview [Logs]  
            No file is changed.
          • ⚠️preview/billing/mgmt/2018-03-01-preview [Logs]  
              No file is changed.
            • ⚠️preview/billing/mgmt/2018-11-01-preview [Logs]  
                No file is changed.

              @openapi-sdkautomation
              Copy link

              openapi-sdkautomation bot commented Feb 4, 2020 •
              edited
              Loading

              azure-sdk-for-python - Release

              ️✔️ succeeded [Logs] [Expand Details]
              • ️✔️ Generate from fbe8275 with merge commit b53a498. SDK Automation 13.0.17.20191226.1
              • ️✔️azure-mgmt-billing [Logs]  [Release SDK Changes] 
                [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)

              @openapi-sdkautomation
              Copy link

              openapi-sdkautomation bot commented Feb 4, 2020 •
              edited
              Loading

              azure-sdk-for-net - Release

              ️✔️ succeeded [Logs] [Expand Details]

              @openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Feb 4, 2020
              Closed
              @asarkar84
              Removing unsupported LineOfCredit API
              91bb453 
              Removing unsupported LineOfCredit API
              @openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Feb 4, 2020
              Closed
              @azure-pipelines
              Copy link

              Azure Pipelines successfully started running 1 pipeline(s).

              @asarkar84 asarkar84 changed the title Correcting the Invoicing Enums as per the actual implementation. Removing LineOfCredit API from 2019 version since it was not supported ever. [BillingRP] Correcting the API response as per the actual implementation. Removing LineOfCredit API from 2019 version since it was never supported. Feb 4, 2020
              @azure-pipelines
              Copy link

              Azure Pipelines successfully started running 1 pipeline(s).

              This was referenced Feb 4, 2020
              Closed
              Closed
              Closed
              Closed
              Closed
              Closed
              @azure-pipelines
              Copy link

              Azure Pipelines successfully started running 1 pipeline(s).

              3 similar comments
              @azure-pipelines
              Copy link

              Azure Pipelines successfully started running 1 pipeline(s).

              @azure-pipelines
              Copy link

              Azure Pipelines successfully started running 1 pipeline(s).

              @azure-pipelines
              Copy link

              Azure Pipelines successfully started running 1 pipeline(s).

              @asarkar84 asarkar84 changed the title [BillingRP] Correcting the API response as per the actual implementation. Removing LineOfCredit API from 2019 version since it was never supported. [BillingRP] Correcting the API response as per the actual implementation. Removing LineOfCredit API from 2019 version, it was never supported. Feb 4, 2020
              @azure-pipelines
              Copy link

              Azure Pipelines successfully started running 1 pipeline(s).

              @asarkar84
              Copy link
              Contributor Author

              @NullMDR Please merge this PR. Thanks!

              @PhoenixHe-NV PhoenixHe-NV merged commit b53a498 into Azure:master Feb 5, 2020
              ssripadham pushed a commit to ssripadham/azure-rest-api-specs that referenced this pull request Feb 21, 2020
              @asarkar84 @ssripadham
              [BillingRP] Correcting the API response as per the actual implementat…
              3be2508 
              …ion. Removing LineOfCredit API from 2019 version, it was never supported. (Azure#8290)

* Added missing fields and corrected enum values as per actual implementation

* Removing unsupported LineOfCredit API

Removing unsupported LineOfCredit API

* Delete IncreaseLineOfCreditBySubscription.json
              00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
              @asarkar84 @00Kai0
              [BillingRP] Correcting the API response as per the actual implementat…
              9286d4e 
              …ion. Removing LineOfCredit API from 2019 version, it was never supported. (Azure#8290)

* Added missing fields and corrected enum values as per actual implementation

* Removing unsupported LineOfCredit API

Removing unsupported LineOfCredit API

* Delete IncreaseLineOfCreditBySubscription.json
              Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
              Reviewers

              @PhoenixHe-NV PhoenixHe-NV PhoenixHe-NV approved these changes

              @wilcobmsft wilcobmsft Awaiting requested review from wilcobmsft wilcobmsft is a code owner

              Assignees

              @PhoenixHe-NV PhoenixHe-NV

              Labels
              None yet
              Projects
              None yet
              Milestone
              No milestone
              Development

              Successfully merging this pull request may close these issues.
              2 participants
              @asarkar84 @PhoenixHe-NV